sensors: Add scd30.force_calibration remote command#52
Draft
Conversation
Member
|
Great use of the golioth commands. This is certainly a power-user type feature, but I think it's good that it's there. It might be a good idea to log or record somewhere that the FRC was issued in some way ( and ideally perhaps what the frc value was? I don't think the sensor exposes that but perhaps the previous sensor value is good enough). That way someone looking at analysis could distinguish which sensors had an FRC vs ASC. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
scd30.force_calibrationRPC command that forces a calibration of the SCD30 CO2 sensor, in addition to the infrastructure necessary to allow sensors to implement commands.