Add Taproot Script Construction #69
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SachinMeier
commented
Feb 1, 2023
SachinMeier
commented
Feb 1, 2023
SachinMeier
changed the title
SachinMeier
changed the title
…ing duplicate keys
…aproot-script-creation
SachinMeier
changed the title
Adaptor Signatures
joaothallis
reviewed
Mar 20, 2023
| @doc """ | ||
| parse takes binary or string representation | ||
| of an extended key and parses it to an extended key object | ||
| returns {:error, msg} on failure |
There was a problem hiding this comment.
I think you don't need to document the response in @doc because it's already documented on the spec. I think a doc test is more useful
Suggested change
| returns {:error, msg} on failure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add function to
ScriptModule to allow user to create a Taproot output from script only, key only, or both