Open
Conversation
Owner
There was a problem hiding this comment.
Please make sure to work on the trunk. You should not use mb_strtoupper and permissions class is lowercase!
Contributor
There was a problem hiding this comment.
Hi,
the good lines should be like that ?
use robertheim\activitystats\permissions;
$lang = array_merge($lang, array(
'ACL_'.utf8_strtoupper(permissions::SEE_STATS) => 'Poò vedere le statistiche di attività',
Contributor
|
Hi @uzz75, could you update this, please ? |
Contributor
Author
|
Hi @Galixte Did some update. |
Contributor
|
Hi @uzz75, do you want any help to submit a new PR ? |
Contributor
Author
|
Hi, Yes. |
Contributor
|
yes, you did those changes: uzz75@25d440c. Otherwise, i have submit you a fix, here: uzz75#1 (for this request: #35 (comment)). @RobertHeim, i think it's ok now ? |
@uzz75 accept by merging (merge button in bottom) to fix this mistake. ;)
Fix a mistake
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.