Feat: Popover #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinYang11
reviewed
Mar 22, 2023
Owner
RobinYang11
left a comment
RobinYang11
left a comment
There was a problem hiding this comment.
reconsitution use createPortal
| * @returns | ||
| */ | ||
| export function getWindowSize() { | ||
| const el = document.createElement('div'); |
Owner
There was a problem hiding this comment.
tips
你了解createPortal() 函数吗？能不能 把动态元素限制在指定的元素内 而不是append 到body上。放到body下，当页面滚动，你的浮框不能跟随！
Owner
There was a problem hiding this comment.
please refer https://react.dev/reference/react-dom/createPortal
Author
There was a problem hiding this comment.
没注意, 逻辑上无论是自定义children还是直接append body, 最终还是这么加的, 可以提供一个getPopupContainer参数
如需跟随滚动修改fixed为absolute即可
Owner
|
please refer https://react.dev/reference/react-dom/createPortal |
Author
|
More Feature |
Author
|
有亿点报错, 搞不定, 等重构吧 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
boss直聘