-
-
Notifications
You must be signed in to change notification settings - Fork 227
ENH: Two stage rocket example. #913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
ENH: Two stage rocket example. #913
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Gui-FernandesBR. Thank you for the feedback. I'm colorblind and I make bad color choices from time to time. I will change it throughout the week.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gui-FernandesBR
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linters not passing... Could you check it please?
Important: Do you want to merge this PR or was it created just for learning purposes?
@Gui-FernandesBR I created the PR for two reasons:
About merging this PR, here's two important points:
In other words, my engineering judgment is that it's best to fix those two items above first, and then merge a proper example. Correct me if I'm wrong, but there's a plan to implement better multi stage capabilities in the near future, so fixing those small problems would certainly fit. I also believe I have some papers with trajectory data for VSB 30, SS-520, some NASA examples, that might make up for a better example. I didn't try to use those due to the lack of time for the registration, which ended yesterday. What do you think? Seems reasonable to me to fix these small things, and use an example from a real rocket, if possible, for the merge. It would be useful during the implementation of better multi stage capabilities too. |

Pull request type
Other (please describe): Added example of a 2 stage rocket.
Checklist
Docs have been reviewed and added / updated
Lint (black rocketpy/ tests/) has passed locally
Current behavior
There are no examples of 2 stage rockets available.
New behavior
This PR adds a simple example using the already existent Andromeda rocket.
Key features:
This adds an ipynotebook called
two_stage_example.ipynbin thedocs/examplefolder.Breaking change
No
Additional information
Two stage rocket motor example done as part of the selection process for the RocketPy team of 2026.
I know better multi stage support is planned in RocketPy for the near future. I'm interested in contributing with that. The notebook has a few comments on problems I found during the implementation.
Unfortunately, due to time constraints I had to keep the example simple. I plan on updating it using data from rockets VSB-30 or SS-520.