Skip to content

perf(refactor): consolidate getState calls in resolveWebviewView #11320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daniel-lxs merged 2 commits into from
Feb 9, 2026
Merged

perf(refactor): consolidate getState calls in resolveWebviewView #11320

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5519dcd
perf(refactor): consolidate getState calls in resolveWebviewView
0xMink Feb 8, 2026
574faa7
fix: keep getState consolidation non-blocking to avoid delaying webvi…
daniel-lxs Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions src/core/webview/ClineProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -757,6 +757,8 @@ export class ClineProvider
terminalZshP10k = false,
terminalPowershellCounter = false,
terminalZdotdir = false,
ttsEnabled,
ttsSpeed,
}) => {
Terminal.setShellIntegrationTimeout(terminalShellIntegrationTimeout)
Terminal.setShellIntegrationDisabled(terminalShellIntegrationDisabled)
Expand All @@ -766,17 +768,11 @@ export class ClineProvider
Terminal.setTerminalZshP10k(terminalZshP10k)
Terminal.setPowershellCounter(terminalPowershellCounter)
Terminal.setTerminalZdotdir(terminalZdotdir)
setTtsEnabled(ttsEnabled ?? false)
setTtsSpeed(ttsSpeed ?? 1)
},
)

this.getState().then(({ ttsEnabled }) => {
setTtsEnabled(ttsEnabled ?? false)
})

this.getState().then(({ ttsSpeed }) => {
setTtsSpeed(ttsSpeed ?? 1)
})

// Set up webview options with proper resource roots
const resourceRoots = [this.contextProxy.extensionUri]

Expand Down
Loading