perf: consolidate three getState() calls into single await in resolveWebviewView#11321
Draft
roomote[bot] wants to merge 1 commit intomainfrom
Draft
perf: consolidate three getState() calls into single await in resolveWebviewView#11321roomote[bot] wants to merge 1 commit intomainfrom
roomote[bot] wants to merge 1 commit intomainfrom
Conversation
Contributor
Author
Review complete. No issues found. The consolidation of three fire-and-forget Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to address Issue #11319 by consolidating three separate
this.getState().then(...)calls into a singleawait this.getState()with destructuring inresolveWebviewView().Changes
this.getState().then(...)calls (terminal settings, ttsEnabled, ttsSpeed) with a singleawait this.getState()and destructuringterminalShellIntegrationTimeout = Terminal.defaultShellIntegrationTimeout,ttsEnabled ?? false,ttsSpeed ?? 1, etc.Why
getState()executions during view activationresolveWebviewViewis alreadyasync, soawaitis idiomatic hereTest plan
Closes #11319. Feedback and guidance are welcome.
Important
Consolidates multiple
getState()calls into a single await with destructuring inresolveWebviewView()ofClineProvider.ts, improving performance and consistency without changing behavior.this.getState().then(...)calls into a singleawait this.getState()with destructuring inresolveWebviewView()inClineProvider.ts.terminalShellIntegrationTimeout,ttsEnabled,ttsSpeed, etc.getState()calls from three to one.resolveWebviewViewremainsasync, aligning with idiomatic usage.This description was created by
for 53fffd8. You can customize this summary. It will automatically update as commits are pushed.