deployments: relevant addresses #52 #64
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
You should pull master in here so you can also include the Base recipient address. |
forrestnorwood
suggested changes
Aug 15, 2023
Contributor
forrestnorwood
left a comment
forrestnorwood
left a comment
There was a problem hiding this comment.
The fee recipient addresses can be queried from the chain and I think they're out of place on Deployments with our smart contract addresses.
I do want to include your changes to the API page though, so let's scrap the recipient addresses for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds the protocol fee recipient to the deployments page. also opens #63 as a next step to improve the styling of the documentation.