Target declaration refactor #491
Draft
+612
−102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firestar99
force-pushed
the
target-decl
branch
from
c84649b to
052cb76
Compare
Firestar99
force-pushed
the
target-decl
branch
from
052cb76 to
a9c36bd
Compare
… target declaration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #484
Supersedes #311
Refactors the target declaration within
rustc_codegen_spirvto no longer be dependent on thespirv_tools::TargetEnvenum, but a custom representation withinrustc_codegen_spirvitself. The newenum SpirvTargetfirst splits into "types of targets", likeVulkanTarget,UniversalTargetandOpenGLTarget, which can represent arbitrary versions of e.g. Vulkan. This is heavily inspired by @eddyb's feedback in #311 (comment). Also see #484 refactoring spirv-builder's target declaration to not do any target validation, but leave that to the codegen backend aka this PR.This is a prerequisite for adding naga transpilation targets in the followup PR #493. And opens up the path to make the
spirv-toolsdependency optional.