chore: update cpal to latest Git, fix conflict #803
Merged
+208
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philpax
force-pushed
the
latest-cpal-fixes
branch
from
528137e to
6851f06
Compare
…ce` with `into_inner`
philpax
force-pushed
the
latest-cpal-fixes
branch
from
6851f06 to
57b2f0c
Compare
Member
|
Thanks for this preparatory work. Now that RustAudio/cpal#1011 is merged, we can also enable the |
Contributor
Author
|
Done and updated to the latest cpal 🙂 |
Member
|
I'd like to release v0.17 soon. call for final testing! |
Contributor
Author
|
I'm currently on holiday and can't update my PRs, but that seems fine at a glance! Feel free to use this PR / close it / do whatever you need to 🙂 |
Member
|
Updated it to latest cpal master. |
Member
|
Just released cpal v0.1.70. Updating this PR to match and merging when the CI passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a prospective update of the
cpaldependency to the latest Git version. It is not intended to be merged (at least until the nextcpalrelease is cut); instead, it's intended as a version ofrodiothat can have itscpalpatched with a fork of the ~currentcpalHEAD (e.g. my RustAudio/cpal#1027).The only changes so far:
cargo update -p objc2to break a dependency resolution conflictFrom<Input> for cpal::DevicewithInput::into_inner, ascpalnow has a conflicting trait implementation.I considered implementing(theInto, but the asymmetry of not having theFromis generally frowned upon.Fromblanket impl blocks this)cpal-shared-stdcxxfeature, which activates the oboe backend for cpal, which has since been removed