ram usage ui distortion fix #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
The distortion is still there. In my opinion, it'd be better to tune the UI than change the code. A simple UI tweak, like what I did with the status indicators (an extra white space in [ ON]) would be enough to fix this :) |
Author
I added more spaces to the whole ui as suggested by u, tho the memory one might need one less white space ..not really sure , tho i have tried to mimic with hard coded values and it shows symmetrical |
Author
|
Kindly review the PR |
Owner
|
Oh my god!! I am so sorry. I was quite busy. Sorry but your modification doesn't make any difference. Adding spaces on both sides still won't solve the UI distortion. If you are still interested in working on this issue, please test your code on a live Linux installation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed the right align to memory value in a 5-character field
removed a space at the end