Skip to content

Conversation

@stefpiatek
Copy link
Contributor

@stefpiatek stefpiatek commented Dec 22, 2025

Description

Fixes #231, allowing OMOP ES batched extract to be parsed by PIXL

Type of change

Please delete options accordingly to the description.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Suggested Checklist

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have passed on my local host device. (see further details at the CONTRIBUTING document)
  • Make sure your branch is up-to-date with main branch. See CONTRIBUTING for a general example to syncronise your branch with the main branch.
  • I have requested review to this PR.
  • I have addressed and marked as resolved all the review comments in my PR.
  • Finally, I have selected squash and merge

@stefpiatek stefpiatek requested a review from milanmlft December 22, 2025 16:50
@codecov
Copy link

codecov bot commented Dec 22, 2025

Codecov Report

❌ Patch coverage is 95.45455% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.89%. Comparing base (881acca) to head (b72940c).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cli/src/pixl_cli/_io.py 91.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #616      +/-   ##
==========================================
+ Coverage   87.76%   87.89%   +0.12%     
==========================================
  Files          76       76              
  Lines        3581     3619      +38     
==========================================
+ Hits         3143     3181      +38     
  Misses        438      438              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stefpiatek stefpiatek changed the title Add example batched omop files Read in parquet OMOP datasets Dec 22, 2025
Copy link
Member

@milanmlft milanmlft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@stefpiatek stefpiatek enabled auto-merge (squash) December 30, 2025 14:43
@stefpiatek stefpiatek merged commit 8ca52a9 into main Dec 30, 2025
11 checks passed
@stefpiatek stefpiatek deleted the stefpiatek/read_omop_es_batch branch December 30, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Accept OMOP ES batches

3 participants