Skip to content

Conversation

@stefpiatek
Copy link
Contributor

And updates to TRE uploader

@stefpiatek stefpiatek requested a review from milanmlft December 23, 2025 11:47
@codecov
Copy link

codecov bot commented Dec 23, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 87.42%. Comparing base (e1cab35) to head (2beea6d).
⚠️ Report is 10 commits behind head on milanmlft/606-add-api-uploader.

Files with missing lines Patch % Lines
pixl_core/src/core/uploader/_treapi.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                        Coverage Diff                         @@
##           milanmlft/606-add-api-uploader     #618      +/-   ##
==================================================================
+ Coverage                           85.07%   87.42%   +2.35%     
==================================================================
  Files                                  73       77       +4     
  Lines                                3343     3650     +307     
==================================================================
+ Hits                                 2844     3191     +347     
+ Misses                                499      459      -40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@milanmlft milanmlft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@milanmlft
Copy link
Member

I think to fix tests just remove all of

mock_flush = mocker.patch.object(mock_uploader, "flush")

mock_flush.assert_called_once()

mock_flush = mocker.patch.object(mock_uploader, "flush")

mock_flush.assert_called_once()

@stefpiatek stefpiatek merged commit 12b58e9 into milanmlft/606-add-api-uploader Dec 30, 2025
10 of 11 checks passed
@stefpiatek stefpiatek deleted the stefpiatek/education-ngtube branch December 30, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants