Skip to content

Conversation

@marcorosa
Copy link
Member

Added

  • support for haiku

Fixed

  • ui scroll bug when setting weights for heatmap

dependabot bot and others added 18 commits December 7, 2025 19:06
Bumps [weasyprint](https://github.com/Kozea/WeasyPrint) from 66.0 to 67.0.
- [Release notes](https://github.com/Kozea/WeasyPrint/releases)
- [Changelog](https://github.com/Kozea/WeasyPrint/blob/main/docs/changelog.rst)
- [Commits](Kozea/WeasyPrint@v66.0...v67.0)

---
updated-dependencies:
- dependency-name: weasyprint
  dependency-version: '67.0'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [faiss-cpu](https://github.com/kyamagu/faiss-wheels) from 1.13.0 to 1.13.1.
- [Release notes](https://github.com/kyamagu/faiss-wheels/releases)
- [Commits](faiss-wheels/faiss-wheels@v1.13.0...v1.13.1)

---
updated-dependencies:
- dependency-name: faiss-cpu
  dependency-version: 1.13.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
…weasyprint-67.0

Bump weasyprint from 66.0 to 67.0 in /backend-agent
…faiss-cpu-1.13.1

Bump faiss-cpu from 1.13.0 to 1.13.1 in /backend-agent
Bumps [sentence-transformers](https://github.com/huggingface/sentence-transformers) from 5.1.2 to 5.2.0.
- [Release notes](https://github.com/huggingface/sentence-transformers/releases)
- [Commits](huggingface/sentence-transformers@v5.1.2...v5.2.0)

---
updated-dependencies:
- dependency-name: sentence-transformers
  dependency-version: 5.2.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
…sentence-transformers-5.2.0

Bump sentence-transformers from 5.1.2 to 5.2.0 in /backend-agent
Bumps [sap-ai-sdk-gen[all]](https://www.sap.com/) from 5.9.0 to 5.10.0.

---
updated-dependencies:
- dependency-name: sap-ai-sdk-gen[all]
  dependency-version: 5.10.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [faiss-cpu](https://github.com/kyamagu/faiss-wheels) from 1.13.1 to 1.13.2.
- [Release notes](https://github.com/kyamagu/faiss-wheels/releases)
- [Commits](faiss-wheels/faiss-wheels@v1.13.1...v1.13.2)

---
updated-dependencies:
- dependency-name: faiss-cpu
  dependency-version: 1.13.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
…sap-ai-sdk-gen-all--5.10.0

Bump sap-ai-sdk-gen[all] from 5.9.0 to 5.10.0 in /backend-agent
…faiss-cpu-1.13.2

Bump faiss-cpu from 1.13.1 to 1.13.2 in /backend-agent
Bumps [qs](https://github.com/ljharb/qs) and [body-parser](https://github.com/expressjs/body-parser). These dependencies needed to be updated together.

Updates `qs` from 6.14.0 to 6.14.1
- [Changelog](https://github.com/ljharb/qs/blob/main/CHANGELOG.md)
- [Commits](ljharb/qs@v6.14.0...v6.14.1)

Updates `body-parser` from 1.20.3 to 1.20.4
- [Release notes](https://github.com/expressjs/body-parser/releases)
- [Changelog](https://github.com/expressjs/body-parser/blob/master/HISTORY.md)
- [Commits](expressjs/body-parser@1.20.3...1.20.4)

---
updated-dependencies:
- dependency-name: qs
  dependency-version: 6.14.1
  dependency-type: indirect
- dependency-name: body-parser
  dependency-version: 1.20.4
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
…ti-a0817b5bb4

Bump qs and body-parser in /frontend
@marcorosa marcorosa requested a review from a team as a code owner January 9, 2026 15:16
@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

This update introduces enhancements across both the backend and frontend of the application. The backend sees the addition of a new model variant supported by Anthropic. Dependencies are upgraded, aligning with minor version bumps in the project's versioning. The frontend improves usability with changes in dialog styling, providing better display scalability.

Walkthrough

  • New Feature: Added support for 'anthropic--claude-4.5-haiku' model variant.
  • Chore: Updated dependencies and incremented version numbers for backend and frontend.
  • Style: Improved CSS styling in the weight dialog to enhance user experience on the frontend.
  • Refactor: Simplified logic for reloading heatmap data by removing conditional checks post dialog closure.

Model: gpt-4o-2024-08-06 | Prompt Tokens: 1233 | Completion Tokens: 147

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's a collaborative code review powered by AI assistance. These suggestions offer potential improvements and insights to consider for your project. Please treat AI recommendations as helpful guidance rather than definitive solutions. Your expertise and judgment remain the most important factors in making the right decisions for your code. Use what resonates with you and feel confident in your choices as the developer.


Always critique what AI says. Do not let AI replace YOUR I.
Model: claude-sonnet-4-20250514 | Prompt Tokens: 2445 | Completion Tokens: 907

Comment on lines +252 to 255
dialogRef.afterClosed().subscribe(() => {
// Reload the heatmap data after weights successfully updated or canceled
this.loadHeatmapData();
}
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic change to always reload heatmap data regardless of the dialog result may not be optimal. Consider reloading only when changes were actually made to avoid unnecessary API calls and improve performance.

dialogRef.afterClosed().subscribe(result => {
  if (result === true) {
    // Only reload when weights were successfully updated
    this.loadHeatmapData();
  }
});

Alternatively, if you need to handle both success and cancellation scenarios differently, use a more descriptive result object:

dialogRef.afterClosed().subscribe(result => {
  if (result?.updated === true) {
    this.loadHeatmapData();
  }
});

Comment on lines -23 to 35
.input-container {
.weight-form-container {
width: 60%;
margin: auto;
padding-top: 10px;
overflow-y: auto;
}

.weight-form-section {
width: 90%;
margin: auto;
max-height: 70vh;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CSS structure could be improved for better maintainability. Consider using more semantic naming and consistent spacing units.

.dialog-container {
  padding: 1rem;
  max-height: 90vh;
}

.weight-form-container {
  width: 60%;
  margin: 0 auto;
  padding-top: 0.625rem;
  overflow-y: auto;
}

.weight-form-section {
  width: 90%;
  margin: 0 auto;
  max-height: 70vh;
  overflow-y: auto; /* Add this for consistency */
}

Also consider using CSS custom properties for repeated values like widths and margins to improve maintainability.

Comment on lines +7 to 19
<div class="weight-form-container">
<div class="weight-form-section">
<form>
<div *ngFor="let attack of attackNames">
<mat-form-field appearance="outline" class="form-field">
<mat-label>{{ attack }}</mat-label>
<input matInput type="number" min="0" step="1" [(ngModel)]="currentWeights[attack]"
name="{{ attack }}" />
</mat-form-field>
</div>
</form>
</div>
</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The HTML structure has improved with better semantic containers, but consider adding accessibility attributes and handling potential performance issues with large lists.

<div class="weight-form-container">
    <div class="weight-form-section" role="form" aria-label="Attack weights configuration">
        <form>
            <div *ngFor="let attack of attackNames; trackBy: trackByAttackName">
                <mat-form-field appearance="outline" class="form-field">
                    <mat-label>{{ attack }}</mat-label>
                    <input 
                        matInput 
                        type="number" 
                        min="0" 
                        step="1" 
                        [(ngModel)]="currentWeights[attack]"
                        [name]="attack"
                        [attr.aria-label]="'Weight for ' + attack" />
                </mat-form-field>
            </div>
        </form>
    </div>
</div>

Add a trackBy function to the component for better performance:

trackByAttackName(index: number, attack: string): string {
  return attack;
}

@marcorosa marcorosa merged commit f21f8ef into main Jan 9, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant