-
Notifications
You must be signed in to change notification settings - Fork 70
[GSMG] Add new object type #593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
mseich
wants to merge
58
commits into
SAP:main
Choose a base branch
from
mseich:feature/gsmg
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 41 commits
Commits
Show all changes
58 commits
Select commit
Hold shift + click to select a range
0370149
Update gsmp-v1.json
mseich 74d0731
Update zif_aff_gsmp_v1.intf.abap
mseich e9c6fd4
Update gsmp-v1.json
mseich aa1a675
Update zif_aff_gsmp_v1.intf.abap
mseich 2375a38
Update gsmp-v1.json
mseich 588a57f
Update zif_aff_gsmp_v1.intf.abap
mseich fe66017
Merge branch 'SAP:main' into main
mseich 3af26d3
Merge branch 'SAP:main' into main
mseich 6a0f91d
Merge branch 'SAP:main' into main
mseich 1dc1a0b
Merge branch 'SAP:main' into main
mseich 370a0e3
Add files for GSMG
mseich a777188
Update file-formats/gsmg/examples/z_aff_example_gsmg.gsmg.json
mseich 2898e05
Update file-formats/gsmg/type/zif_aff_gsmg_v1.intf.abap
mseich e0b5e18
Update file-formats/gsmg/type/zif_aff_gsmg_v1.intf.abap
mseich 5bbb486
Update file-formats/gsmg/type/zif_aff_gsmg_v1.intf.abap
mseich b7a4c18
Update file-formats/gsmg/type/zif_aff_gsmg_v1.intf.abap
mseich 1fe7cad
Update file-formats/gsmg/type/zif_aff_gsmg_v1.intf.abap
mseich a13a41b
Update file-formats/gsmg/type/zif_aff_gsmg_v1.intf.abap
mseich 13820b5
Update file-formats/gsmg/README.md
mseich 4b2edfa
Update zif_aff_gsmg_v1.intf.abap
mseich 071a0fe
Update zif_aff_gsmg_v1.intf.json
mseich ca1ca16
Update gsmg-v1.json
mseich ec6075d
Update z_aff_example_gsmg.gsmg.json
mseich ce1b698
Update zif_aff_gsmg_v1.intf.abap
mseich 222c9c8
EOL Unix style (LF)
mseich 752ac82
Get rid of enums
mseich 7c34be4
Auto enums
mseich 6975501
fixed enum
mseich 65de592
Update zif_aff_gsmg_v1.intf.abap
mseich 4fda525
Update gsmg-v1.json
mseich cd87281
Merge branch 'main' into feature/gsmg
albertmink 1ec018b
Merge branch 'main' into feature/gsmg
albertmink acbd246
Update z_aff_example_gsmg.gsmg.json
mseich 5676338
Update z_aff_example_gsmg.gsmg.json
mseich 332849b
Update z_aff_example_gsmg.gsmg.json
mseich db43d0c
Update z_aff_example_gsmg.gsmg.json
mseich 6f9caec
LF as EOL
mseich cb3be75
LF as EOL
mseich a54a743
LF as EOL Part 3
mseich cfc32c5
Delete .vscode/settings.json
mseich f939a76
Merge branch 'main' into feature/gsmg
mseich a4778d7
Merge branch 'main' into feature/gsmg
albertmink 880cba2
Update file-formats/gsmg/README.md
mseich 7d6f46d
Update file-formats/gsmg/examples/z_aff_example_gsmg.gsmg.json
mseich e8a7d73
exceptions -> exception
mseich 639368d
Merge branch 'main' into feature/gsmg
schneidermic0 c447d3a
Merge branch 'main' into feature/gsmg
schneidermic0 328b92b
Fix schema due to changes in issue #582
schneidermic0 7c92e51
Merge branch 'main' into feature/gsmg
schneidermic0 a1b3e5a
Merge branch 'main' into feature/gsmg
schneidermic0 25b0135
remove long description
mseich 7e7859c
Fix language field according to BCP47
schneidermic0 4b3fdc5
Merge branch 'main' into feature/gsmg
schneidermic0 a3a5de8
Merge branch 'main' into feature/gsmg
albertmink ae2976c
Fix abaplint issue
schneidermic0 cf1e23b
Merge branch 'main' into feature/gsmg
schneidermic0 d287a97
Merge branch 'main' into feature/gsmg
schneidermic0 125a8fa
Merge branch 'main' into feature/gsmg
schneidermic0 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| # GSMG File Format | ||
|
|
||
| File | Cardinality | Definition | Schema | Example | ||
| :--- | :--- | :--- | :--- | :--- | ||
| `<name>.gsmg.json` | 1 | [`zif_aff_gsmg_v1.intf.abap`](./type/zif_aff_gsmg_v1.intf.abap) | [`gsmg-v1.json`](./gsmg-v1.json) | | [z_aff_example_gsmg.gsmg.json](./examples/z_aff_example_gsmg.gsmg.json) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| { | ||
| "formatVersion": "1", | ||
| "header": { | ||
| "description": "For testing.", | ||
| "originalLanguage": "en", | ||
| "abapLanguageVersion": "standard" | ||
mseich marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| }, | ||
| "generalInformation": { | ||
| "category": "usage", | ||
| "detailedDescription": "This Metric Group is for testing." | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,117 @@ | ||
| { | ||
| "$comment": "This file is autogenerated, do not edit manually, see https://github.com/SAP/abap-file-formats for more information.", | ||
| "$schema": "https://json-schema.org/draft/2020-12/schema", | ||
| "$id": "https://github.com/SAP/abap-file-formats/blob/main/file-formats/gsmg/gsmg-v1.json", | ||
| "title": "Metric Group", | ||
| "description": "Metric Group (GSMG)", | ||
| "type": "object", | ||
| "properties": { | ||
| "formatVersion": { | ||
| "title": "ABAP File Format Version", | ||
| "description": "The ABAP file format version", | ||
| "type": "string", | ||
| "const": "1" | ||
| }, | ||
| "header": { | ||
| "title": "Header", | ||
| "description": "Header", | ||
| "type": "object", | ||
| "properties": { | ||
| "description": { | ||
| "title": "Description", | ||
| "description": "Description of the ABAP object", | ||
| "type": "string", | ||
| "maxLength": 60 | ||
| }, | ||
| "originalLanguage": { | ||
| "title": "Original Language", | ||
| "description": "Original language of the ABAP object", | ||
| "type": "string", | ||
| "minLength": 2, | ||
| "maxLength": 2, | ||
| "pattern": "^[a-z]+$" | ||
| }, | ||
| "abapLanguageVersion": { | ||
| "title": "ABAP Language Version", | ||
| "description": "ABAP language version", | ||
| "type": "string", | ||
| "enum": [ | ||
| "standard", | ||
| "cloudDevelopment" | ||
| ], | ||
| "enumTitles": [ | ||
| "Standard", | ||
| "ABAP Cloud Development" | ||
| ], | ||
| "enumDescriptions": [ | ||
| "Standard", | ||
| "ABAP cloud development" | ||
| ], | ||
| "default": "standard" | ||
| } | ||
| }, | ||
| "additionalProperties": false, | ||
| "required": [ | ||
| "description", | ||
| "originalLanguage" | ||
| ] | ||
| }, | ||
| "generalInformation": { | ||
| "title": "General Information", | ||
| "description": "General information", | ||
| "type": "object", | ||
| "properties": { | ||
| "category": { | ||
| "title": "Category", | ||
| "description": "Category", | ||
| "type": "string", | ||
| "enum": [ | ||
| "availability", | ||
| "performance", | ||
| "exceptions", | ||
| "configuration", | ||
| "usage", | ||
| "selfMonitoring", | ||
| "metering" | ||
| ], | ||
| "enumTitles": [ | ||
| "Availability", | ||
| "Performance", | ||
| "Exceptions", | ||
| "Configuration", | ||
| "Usage", | ||
| "Self Monitoring", | ||
| "Metering" | ||
| ], | ||
| "enumDescriptions": [ | ||
| "Availability", | ||
| "Performance", | ||
| "Exceptions", | ||
| "Configuration", | ||
| "Usage", | ||
| "Self monitoring", | ||
| "Metering" | ||
| ], | ||
| "default": "usage" | ||
| }, | ||
| "detailedDescription": { | ||
| "title": "Detailed Description", | ||
| "description": "Detailed description", | ||
| "type": "string", | ||
| "maxLength": 255 | ||
| } | ||
| }, | ||
| "additionalProperties": false, | ||
| "required": [ | ||
| "category", | ||
| "detailedDescription" | ||
| ] | ||
| } | ||
| }, | ||
| "additionalProperties": false, | ||
| "required": [ | ||
| "formatVersion", | ||
| "header", | ||
| "generalInformation" | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,92 @@ | ||
| INTERFACE zif_aff_gsmg_v1 | ||
| PUBLIC. | ||
|
|
||
| TYPES: | ||
|
|
||
| "! <p class="shorttext">Category</p> | ||
| "! Category | ||
| "! $values {@link zif_aff_gsmg_v1.data:co_category} | ||
| "! $default {@link zif_aff_gsmg_v1.data:co_category.usage} | ||
| ty_category TYPE c LENGTH 10, | ||
|
|
||
| "! <p class="shorttext">Detailed Description</p> | ||
| "! Detailed description | ||
| ty_detailed_description TYPE c LENGTH 255, | ||
|
|
||
|
|
||
| "! <p class="shorttext">General Information</p> | ||
| "! General information | ||
| BEGIN OF ty_general_information, | ||
| "! <p class="shorttext">Category</p> | ||
| "! Category | ||
| "! $required | ||
| category TYPE ty_category, | ||
|
|
||
| "! <p class="shorttext">Detailed Description</p> | ||
| "! Detailed description | ||
| "! $required | ||
| detailed_description TYPE ty_detailed_description, | ||
|
|
||
| END OF ty_general_information. | ||
|
|
||
|
|
||
| CONSTANTS: | ||
|
|
||
| "! <p class="shorttext">Category</p> | ||
| "! Category | ||
| BEGIN OF co_category, | ||
|
|
||
| "! <p class="shorttext">Availability</p> | ||
| "! Availability | ||
| availability TYPE ty_category VALUE 'AVAIL', | ||
|
|
||
| "! <p class="shorttext">Performance</p> | ||
| "! Performance | ||
| performance TYPE ty_category VALUE 'PERFORM', | ||
|
|
||
| "! <p class="shorttext">Exceptions</p> | ||
| "! Exceptions | ||
| exceptions TYPE ty_category VALUE 'EXCEPTION', | ||
mseich marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| "! <p class="shorttext">Configuration</p> | ||
| "! Configuration | ||
| configuration TYPE ty_category VALUE 'CONFIGURE', | ||
|
|
||
| "! <p class="shorttext">Usage</p> | ||
| "! Usage | ||
| usage TYPE ty_category VALUE 'USAGE', | ||
|
|
||
| "! <p class="shorttext">Self Monitoring</p> | ||
| "! Self monitoring | ||
| self_monitoring TYPE ty_category VALUE 'SELFMON', | ||
|
|
||
| "! <p class="shorttext">Metering</p> | ||
| "! Metering | ||
| metering TYPE ty_category VALUE 'METERING', | ||
|
|
||
| END OF co_category. | ||
|
|
||
|
|
||
|
|
||
| TYPES: | ||
|
|
||
| "! <p class="shorttext">Metric Group</p> | ||
| "! Metric Group (GSMG) | ||
| BEGIN OF ty_main, | ||
|
|
||
| "! $required | ||
| format_version TYPE zif_aff_types_v1=>ty_format_version, | ||
|
|
||
| "! <p class="shorttext">Header</p> | ||
| "! Header | ||
| "! $required | ||
| header TYPE zif_aff_types_v1=>ty_header_60_cloud, | ||
|
|
||
| "! <p class="shorttext">General Information</p> | ||
| "! General information | ||
| "! $required | ||
| general_information TYPE ty_general_information, | ||
|
|
||
| END OF ty_main. | ||
|
|
||
| ENDINTERFACE. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "formatVersion": "1", | ||
| "header": { | ||
| "description": "GSMG AFF Type (Metric Group)", | ||
| "originalLanguage": "en" | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.