Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -79,11 +79,11 @@ public static String serviceNameToBaseJavaClassName( @Nonnull final String servi

formattedName =
formattedName
.replace("ODataServiceFor", "")
.replace("RemoteApiFor", "")
.replace("ApiFor", "")
.replace("Api", "")
.replaceAll("Service$", "");
.replaceAll("O(data|DATA|Data)S(ervice|ERVICE)F(or|OR)", "")
.replaceAll("R(emote|EMOTE)A(pi|PI)F(or|OR)", "")
.replaceAll("A(pi|PI)F(or|OR)", "")
.replaceAll("A(pi|PI)", "")
.replaceAll("S(ervice|ERVICE)$", "");

return formattedName;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,9 @@ private static Stream<Arguments> getClassTestCases()
Arguments.of("Lower,enumeration", "LowerEnumeration"),
Arguments.of("KeepCamelCase", "KeepCamelCase"),
Arguments.of("handle_snake_case", "HandleSnakeCase"),
Arguments.of("OData Service for Business Partner", "BusinessPartner"));
Arguments.of("OData Service for Business Partner", "BusinessPartner"),
Arguments.of("API MATERIAL DOCUMENT SRV", "MATERIALDOCUMENTSRV"),
Arguments.of("MATERIALDOCUMENTSRV", "MATERIALDOCUMENTSRV"));
}

@ParameterizedTest
Expand All @@ -52,7 +54,9 @@ private static Stream<Arguments> getPackageTestCases()
Arguments.of("Lower,enumeration", "lowerenumeration"),
Arguments.of("KeepCamelCase", "keepcamelcase"),
Arguments.of("handle_snake_case", "handlesnakecase"),
Arguments.of("OData Service for Business Partner", "businesspartner"));
Arguments.of("OData Service for Business Partner", "businesspartner"),
Arguments.of("API MATERIAL DOCUMENT SRV", "materialdocumentsrv"),
Arguments.of("materialdocumentsrv", "materialdocumentsrv"));
}

@ParameterizedTest
Expand Down
4 changes: 3 additions & 1 deletion release_notes.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,6 @@

### 🐛 Fixed Issues

-
- Fix unintended modification of `serviceNameMappings.properties` during OData service regeneration altering stored mappings.
Additionally, service name cleanup is now case-insensitive for consistency.