-
Notifications
You must be signed in to change notification settings - Fork 14
Add PTB trigger fields to SRTrigger for SBND #180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Add PTB trigger fields to SRTrigger for SBND #180
Conversation
|
Thanks for the PR @hbjamin! My only comment is whether we can reduce the CAF footprint by declaring |
PetrilloAtWork
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please confirm that double precision is indeed not losing needed precision in the timestamps.
I have also left a suggestion on the documentation format.
|
Thank you for the very important catch. I've update the timestamps to be |
Description
This PR adds PTB trigger information fields to the
SRTriggerclass in the StandardRecord structure, which is required for SBND trigger efficiency studies using zero bias data. HLT and LLT decoded bits and timestamps are stored in separate vectors for easier analysis.git fetchand pulled the latest changes from the branch you're basing your PR against?ClassVersionby one compared to develop in classes_def.xml?