Skip to content

Comments

Feature/fix dev metadata and loading search#60

Merged
pickettd merged 2 commits intomainfrom
feature/fix-dev-metadata-and-loading-search
Jan 16, 2025
Merged

Feature/fix dev metadata and loading search#60
pickettd merged 2 commits intomainfrom
feature/fix-dev-metadata-and-loading-search

Conversation

@pickettd
Copy link
Contributor

Critical Changes

  • Fix the loading logic to not show the spinner if a search returns no results
  • Add some filtering in the search logic to exclude special characters that would show up in the html but not the numeric values (like $,,,%)

Changes

Issues Closed

…youts, and flows for testing on accounts in our flow
… if a search returns nothing. And add logic on the number search to exclude certain special characters that would be in the html but not the numeric value
@pickettd pickettd requested a review from roanbear January 16, 2025 18:51
Copy link
Collaborator

@roanbear roanbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@pickettd pickettd merged commit 9ce14c4 into main Jan 16, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants