Open
Conversation
TheBitShepherd
suggested changes
Jul 20, 2021
tests/test_salesforce_gen.py
Outdated
| class TestSalesforceConnection: | ||
| def test_bad_kwargs(self): | ||
| sfc = SalesforceConnection(None) | ||
| with pytest.raises(exc.DataGenError, match="Unknown argument"): |
Contributor
There was a problem hiding this comment.
Is the unknown argument xyzzy or is it the blah field? It would be nice if the error message included the name of the unknown argument.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unit test for some of the Salesforce query features.