Pre Supernova Support for SNTools #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
April 29, 2025 13:28
… SNEWPY models to the format choices
…e mode and an input and import the model from the correct snewpy.models.____loaders module
… function take mode option as an argument. Allows mode to be used to determine where in SNEWPY to look for the pre sn model.
…g the times list in formats/__init__.py
…ths for ccsn models and pre sn models
…t for presn mode. Allowing start and end times to be given in units of minutes on the command line for presn mode.
JostMigenda
reviewed
Sep 22, 2025
Member
JostMigenda
left a comment
JostMigenda
left a comment
There was a problem hiding this comment.
Thanks @eobrien2502, this looks pretty good already! I’ve left two minor comments, which shouldn’t take much work to resolve; once you’ve done that, I’m happy to merge this and produce a beta for Lucas and others to test.
Before any final release, we should
- finalise time bin size
- check whether the
--modeargument is necessary or whether we can determine that automatically based on the model name - make sure all models are working with the latest release of snewpy (I think that mainly affects Odrzywolek, now?)
- … and update the documentation
…t use of ccsn mode throughout and chnaging the default bin size to 1 second.
Member
|
This looks good, thanks! The failing tests are on an old Python version (which is no longer supported by the latest snewpy version), so we should drop support for that as well. I’ll handle that in a separate PR in a moment and tag a beta release afterwards. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additions and changes that allow SNTools to support the use of Pre Supernova neutrino models within SNEWPY to generate events from those models.