Skip to content

Fix compilation bugs with scala 2.12 #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fupelaqu merged 3 commits into from
Jan 12, 2026
Merged

Fix compilation bugs with scala 2.12 #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
80fa509
fix warning
fupelaqu Jan 12, 2026
1cac421
to fix scala compilation bug with Regex using scala 2.12
fupelaqu Jan 12, 2026
8a5d692
to fix scala compilation bug with implicit using scala 2.12
fupelaqu Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions core/src/main/scala/app/softnetwork/elastic/client/BulkApi.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ import java.time.LocalDate
import java.time.format.DateTimeFormatter
import scala.concurrent.{ExecutionContext, Future}

import scala.language.implicitConversions

/** Bulk API for Elasticsearch clients.
*/
trait BulkApi extends BulkTypes with ElasticClientHelpers {
Expand Down
2 changes: 1 addition & 1 deletion core/src/main/scala/app/softnetwork/elastic/client/ElasticClientHelpers.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ trait ElasticClientHelpers {

val pattern = "^[a-zA-Z0-9._\\-@]+$".r

if (!pattern.matches(trimmed)) {
if (!pattern.pattern.matcher(trimmed).matches()) {
return Some(
ElasticError(
message =
Expand Down
4 changes: 3 additions & 1 deletion sql/src/main/scala/app/softnetwork/elastic/schema/package.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,6 +454,8 @@ package object schema {

}

val aliases = esAliases.aliases.map(entry => entry._1 -> implicitly[Value[_]](entry._2.node))

// 4. Final construction of the Table
Table(
name = name,
Expand All @@ -463,7 +465,7 @@ package object schema {
mappings = esMappings.options,
settings = esSettings.options,
processors = processors.toSeq,
aliases = esAliases.aliases.map(entry => entry._1 -> entry._2.node)
aliases = aliases
).update()
}
}
Expand Down