-
Notifications
You must be signed in to change notification settings - Fork 53
Fix emoji support in comments and project descriptions #1840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Hey, thanks for contributing!
Is your docker compose up? Try with |
|
Also, you need to run the migrations locally and upload the modified schema file |
|
thanks @danidoni So first of all I am trying to run rspec tests on clean App is up, but I see my emoji projects, so resetting the database. IIUC the right command is
This fails with: What am I doing wrong? |
|
I would check out master and run
`docker-compose run --rm hackweek bundle exec rake dev:bootstrap`
to start clean, as documented here: https://github.com/SUSE/hackweek?tab=readme-ov-file#hack-it
|
|
Right, thanks. Checking out from master branch, then running Checking out this branch, re-running Is it safe to assume the problem lies elsewhere? Is there anything else I should do for this PR to be mergeable? |
Co-authored-by: moio <250541+moio@users.noreply.github.com> Signed-off-by: Silvio Moioli <silvio@moioli.net>
ee6ae8b to
24d6444
Compare
|
I don't know what to tell you... I started from a fresh start, on master, and I don't have any error... Did you try removing all containers from that project and rebuild again from scratch? |
Emojis (e.g., 😱) in comments or project descriptions cause HTTP 500. MySQL's
utf8charset only supports 3-byte UTF-8; emojis require 4-byteutf8mb4.Fixes #585.
This was made with Copilot agents as part of experiments for my HackWeek project.
I tested it manually and it works in my environment, as far as I can tell:
docker-compose exec hackweek bundle exec rspecapparently fails mid way for reasons I don’t understand. In logs I see:I hope this helps. Feedback welcome.