Update rubocop-rails 2.34.0 → 2.34.2 (patch) #1844
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.
What changed?
✳️ rubocop-rails (2.34.0 → 2.34.2) · Repo · Changelog
Release Notes
2.34.2
2.34.1
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by 18 commits:
Cut 2.34.2Update ChangelogMerge pull request #1567 from koic/make_rails_presence_allow_index_access_methods[Fix #1565] Make `Rails/Presence` allow index access methodsMerge pull request #1566 from rubocop/dependabot/github_actions/actions/checkout-6Bump actions/checkout from 5 to 6Switch back docs version to masterCut 2.34.1Update ChangelogMerge pull request #1562 from koic/fix_incorrect_autocorrect_for_rails_redirect_back_or_to_copMerge pull request #1560 from davidenglishmusic/presence-cop-comparison-assignment-false-positives[Fix #1561] Fix incorrect autocorrect for `Rails/RedirectBackOrTo`Merge pull request #1559 from koic/fix_incorrect_autocorrect_for_rails_redirect_back_or_to[Fix #1557] Fix false positives for Rails/Presence with comparison and assignment operators[Fix #1558] Fix incorrect autocorrect for `Rails/RedirectBackOrTo`Merge pull request #1556 from koic/fix_an_error_for_rails_envFix an error for `Rails/Env`Switch back docs version to masterCommits
See the full diff on Github. The new version differs by 23 commits:
Release 1.3.6Exclude dependabot updates from release notesThreadPoolExecutor `kill` will `wait_for_termination` in JRuby; ensure TimerSet timer thread shuts down cleanlyFlaky test fix: allow ThreadPool to shutdown before asserting completed_task_count (#1098)Allow TimerTask to be safely restarted after shutdown and avoid duplicate tasks (#1001)Mark RubySingleThreadExecutor as a SerialExecutorServiceAsynchronous pruning for RubyThreadPoolExecutor (#1082)Add Joshua Young to the list of maintainers (#1097)Use typed data APIsUse stdatomic.h on recent macOSBump actions/checkout from 5 to 6Fix multi require concurrent/executor/cached_thread_poolAlways fail-fast: false in CIAvoid creating a Fiber while loading the gemBump actions/checkout from 4 to 5Bump actions/upload-pages-artifact from 3 to 4Fix mistakes in MVar documentationCorrect word in readmeFix typoAdd 3.4 in CIRun tests without the C extension in CIFix guards in specs using C extension classesDocument Bundler workaround for releasingRelease Notes
3.0.2 (from changelog)
3.0.1 (from changelog)
3.0.0 (from changelog)
2.5.5 (from changelog)
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by 15 commits:
bump, changesSupport :name keyword arg for backwards compat, #210Fix missing fork.rbdocsrefactor idle reaping for readabilityfix CI warningfork refactoringci tuningConnection Pool 3.0 (#209)Add benchmark to validate fast path performanceprep for releaseBump actions/checkout from 5 to 6 (#208)Support pop(exception: false) to avoid exceptions as control flow, fixes #207Adjust ractor testing to avoid needless stdout warningsdoc: explain weird codeRelease Notes
2.18.0
2.17.1 (from changelog)
2.17.0
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by 38 commits:
Release 2.18.0Add `allow_control_characters` parsing optionAdd a specific error for unescaped newlinesRemove dead code from JSON::TruffleRuby::GeneratorRemove dead code in benchmark/encoder.rbRelease 2.17.1Fix a regression in parsing of unicode surogate pairsRelease 2.17.0Fix handling of depthFix duplicated test_unsafe_load_with_options test caseReproduce C ext behavior of ignoring mutated depth in arraysTest and restore behavior around to_json changing depthImprove `JSON.load` and `JSON.unsafe_load` to allow passing options as second argumentMerge pull request #909 from nobu/macro_argsFix macro argumentsDon't call to_json on the return value of as_json for Float::NANRespect Coder depth when generatingTest current behavior regarding depth for CoderStop testing on macos-13Don't copy JSON_Generator_State in generate_newDon't write depth to JSON_Generator_State in some casesAdd depth to struct generate_json_dataTest to_json using State#depthTest depthTest that depth of unfrozen State does not changeparser.c: Record escape positions while parsingFix the parser to not accept invalid escapesDon't emit deprecation warnings in State#to_h in TruffleRubyUse booleans in string_scanMove RUBY_TYPED_FROZEN_SHAREABLE macro to json.hSkip test failing with JRuby in CIRactor-shareable JSON::CoderBump actions/checkout from 5 to 6Remove unused symbolsparser.c: Remove unued JSON_ParserStruct.parsing_nameUse #if instead of #ifdef when checking for JSON_DEBUG so debugging code is not generated when JSON_DEBUG=0.Merge pull request #895 from ruby/removed-strnlenstrnlen is not used nowRelease Notes
5.27.0 (from changelog)
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by 15 commits:
Branching minitest to version 5.27.0! Adding post install message announcing the EOL for minitest 5.REVERTED: Removed obsolete conditional for prerecord. For now... Wait for MT6.- Removed obsolete guards around Warning.- Removed obsolete version guards for pattern matching assertions.- Removed obsolete conditional for prerecord+ Use Kernel#warn uplevel argument for nicer warnings. (byroot)Fixed reporter test shape variation warning. (havenwood)+ Removed TestTask::Work#initialize since Queue can now initialize with an Enumerable! AMAZING!- Switched all internal requires to require_relative.- Cleaned up option aliasing a tad.Switched to vim-test in readmeAdded minitest website to readmeanother tweak to GHA config to fix task namesCleaned up GHA configDepfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase.All Depfu comment commands