audit: fix watch rules in artifacts #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If more than one instance of the audit plugin is called with watch rules for the same path but each using different keys, e.g.: SELECT * FROM audit(rules=["-w /etc/passwd -k key1"]) WHERE "key1" IN Tags SELECT * FROM audit(rules=["-w /etc/passwd -k key2"]) WHERE "key2" IN Tags Then it turns out that each event will only be sent to one of the instances. Fix by using the same key for the same paths across instances. The audit plugin reference counts audit rules and duplicates are not a problem.
gosipyan
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If more than one instance of the audit plugin is called with watch rules for the same path, but each using different keys, e.g.:
Then it turns out that any event will only be sent to one of the instances.
Fix by using the same key for the same paths across instances. The audit plugin reference counts audit rules and duplicates are not a problem.