Public is Asset Bundle Loaded / Downloading#5
Open
danoli3 wants to merge 2 commits intoSadPandaStudios:masterfrom
Open
Public is Asset Bundle Loaded / Downloading#5danoli3 wants to merge 2 commits intoSadPandaStudios:masterfrom
danoli3 wants to merge 2 commits intoSadPandaStudios:masterfrom
Conversation
FodderMK
requested changes
May 2, 2018
Collaborator
FodderMK
left a comment
FodderMK
left a comment
There was a problem hiding this comment.
One change request, the rest looks good!
| /// <summary> | ||
| /// Returns if the Asset Bundle is already loaded (out Bundle if loaded) | ||
| /// </summary> | ||
| public bool IsAssetBundleLoaded(string bundleName, out AssetBundle bundle) |
Collaborator
There was a problem hiding this comment.
It's a minor thing, but could you rename this to TryGetAssetBundle? That way it matches c# conventions that have similar functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convenience check methods