-
Notifications
You must be signed in to change notification settings - Fork 86
FE-7563 - Fix Accessibility Issues with Mentions Plugin #7758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| "version": "7.27.1", | ||
| "dev": true, | ||
| "license": "MIT", | ||
| "peer": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: are these dependancy changes expected for this piece of work? It looks like you've changed babel/core to a peer dependency here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good spot I missed that I'd pushed a package-lock update. That shouldn't be in there I don't believe. I'll get it removed.
|
|
||
| &.selected { | ||
| background: #eee; | ||
| color: #000; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question (non-blocking): are there any tokens for these colours?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: I wonder if it'd be better to add the style overrides into the portrait and icon styles instead (at the bottom of the block etc)
// portrait.style
${MentionListItem}.selected & {
color: currentColor;
}
// initials
${StyledPortrait} & {
color: currentColor;
}
// icon.style
${StyledPortrait} & {
color: currentColor;
}
Proposed behaviour
Current behaviour
Checklist
d.tsfile added or updated if requiredQA
Additional context
Testing instructions