test(badge): refine badge tests - (FE-6443) #7759
Open
+21
−106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
paulrobinson88
left a comment
paulrobinson88
left a comment
There was a problem hiding this comment.
Hi Divya, good work on this, just one comment from me.
Thanks.
| }); | ||
| }); | ||
|
|
||
| test("should render with correct styles when onClick is passed and Badge is hovered", async ({ |
Contributor
There was a problem hiding this comment.
comment: This test appears to check that the correct badge and cross styles are applied when using an onClick and the badge is hovered. The Jest test does cover that the cross is rendered but the styles aren't checked. We may want to either add this into Jest, or potentially create an interaction test which could check via a snapshot.
However, as the onClick is deprecated it may not be required, I'll revert to whatever the other reviewer thinks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed behaviour
Eliminated all Playwright tests in badge.pw.tsx except accessibility tests, and added missing test coverage to the Jest test file.
Current behaviour
A number of tests are present in multiple test suites, and certain flaky tests may cause failures or substantially increase execution time.
Checklist
d.tsfile added or updated if requiredQA
Additional context
This should significantly reduce the amount of time taken for Playwright test to run in the Badge component without losing any coverage in Jest.
Testing instructions
Ensure the Playwright tests pass and Chromatic snapshots are correct.