Skip to content

Conversation

@avst-perrygeorge
Copy link
Contributor

JIRA Ticket(s):

Overview

Collaborators

Standards

  • Updated relevant documentation.
  • Added sufficient tests.
  • Commit log is descriptive and succinct.
  • Tested on multiple browsers (ignore if backend-only change).

Considerations

Copy link
Contributor

@Glazy Glazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple things to consider

# Change plan

Move a Subscription to a new Plan. Proration behaviour can optionally be set.
Move a Subscription to a new Plan. If the subscription was created through a checkout link, proration behaviour can optionally be set.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The second half of this is a tricky one. It is unclear how it relates to the ability to "Change plan", can the proration behaviour be changed at this point?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

proration behaviour isn't defined on a subscription level, its just defined for the action. So in this case proration will be applied to just this specific change plan action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants