Skip to content
This repository was archived by the owner on Feb 12, 2022. It is now read-only.

Bug fixes & String concatenation performance improvent#64

Open
nginth wants to merge 3 commits intoSalesforceFoundation:masterfrom
nginth:bugfixes
Open

Bug fixes & String concatenation performance improvent#64
nginth wants to merge 3 commits intoSalesforceFoundation:masterfrom
nginth:bugfixes

Conversation

@nginth
Copy link

@nginth nginth commented Dec 7, 2016

I ran into a few bugs when using ApexDoc for my org. I mainly fixed a NPE when @group-content points to a file that doesn't exist. I also included some (maybe not necessary) performance improvements by changing some string concatenation to StringBuilder appends.

@judisohn
Copy link
Contributor

judisohn commented Dec 8, 2016

Thanks @nginth! Our development team is actively working on other projects so it may be a while before this can be reviewed and considered. We appreciate your support and patience!

@no-stack-dub-sack
Copy link

@nginth I realize this PR is quite old, but I'm attempting to revitalize this project here (I've yet to merge in my first big update, but there's on open PR for it - includes a few new tokens and some other new features), and I noticed this bug and then this PR in my travels. Are you interested in submitting this PR to the new repo once I merge the open PR? If not, I'd be happy to implement the main fix myself and attribute the credit to you. Thanks.

@nginth
Copy link
Author

nginth commented Feb 15, 2019

@no-stack-dub-sack I would be interested in submitting the new PR! I'll subscribe to your open PR and work on getting this one submitted over there when you merge it.

@no-stack-dub-sack
Copy link

@nginth Wow! That was a quick response 😄 There are some pretty significant changes with this first commit, so you likely won't be able to just copy/paste, but some of the sections you edited should be mostly the same. Merging this PR in shortly, see you over there!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants