Refactoring Branch #79
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sasdata/quantities/_units_base.py
Outdated
| si_scaling_factor: float, | ||
| dimensions: Dimensions): | ||
|
|
||
| self.scale = si_scaling_factor |
Contributor
There was a problem hiding this comment.
Is there any reason not to call self.scale self.si_scaling_factor as well?
sasdata/quantities/units.py
Outdated
|
|
||
|
|
||
| # | ||
| # Units by type |
Contributor
There was a problem hiding this comment.
While writing the unit tests for my parser, I had a thought. I think the unit groups should perhaps go into a separate module. To import a unit, we would do
from sasdata.quantities.units import meters. meters_per_second ...'Which makes sense. But to import a unit group, the import statement would look like this.
from sasdata.quantities.units import speed, acceleration ...'Which might be a little confusing because we're importing a unit group from the units module. Its a fairly minor change but having a separate unit group module might make this clearer.
Contributor
Author
There was a problem hiding this comment.
Yeah, sounds like a good plan
DrPaulSharp
force-pushed
the
refactor_24
branch
2 times, most recently
from
a16b0a6 to
e27d0cc
Compare
DrPaulSharp
force-pushed
the
refactor_24
branch
from
6e3ba34 to
c010919
Compare
DrPaulSharp
force-pushed
the
refactor_24
branch
2 times, most recently
from
d4683bd to
3df6e01
Compare
…andards (now looks directly at canSAS_class instead of the group name. This is because the group name is allowed to be anything, but the canSAS_class is fixed. also allowed raw to be none in metadata because raw is not a part of the NXcanSAS standard. also ran ruff which cleaned up the rpm in units and accessors and si.
… raw data loading if present
…examplefile.h5. Also added support for when the NX_class attribute has a canSAS_class name. Also fixed bug when no instrument, sample etc are given in the file.
…multisasentry_multisasdata.h5, nxcansas_1Dand2D_multisasdata.h5, and nxcansas_1Dand2D_multisasentry.h5 test data files
…ged name of parse_float_first to parse_float
…ta and nxcansas_1Dand2D_multisasentry where the detector distance was read wrong because of the difference between node.astype(float)[0] and float(node[0].astype(str))
DrPaulSharp
force-pushed
the
refactor_24
branch
from
b32dbfe to
6f3b4af
Compare
…nd removed for loops and most conditional logic
…d return in NDRebin __call__
…d return in NDRebin __call__
Adding ND rebinner to refactor_24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main branch for the refactoring project