Skip to content

feat: initial-size config and command line#302

Open
RobertMueller2 wants to merge 2 commits intoSatty-org:mainfrom
RobertMueller2:resize_behaviour
Open

feat: initial-size config and command line#302
RobertMueller2 wants to merge 2 commits intoSatty-org:mainfrom
RobertMueller2:resize_behaviour

Conversation

@RobertMueller2
Copy link
Member

@RobertMueller2 RobertMueller2 commented Oct 10, 2025

Closes: #71

Changes fullscreen (command line and config) to use a parameter:

  • all (to cover all screens, probably not working in most compositors, but sets according property on toplevel. This is not the same thing as e.g. sway global fullscreen, btw)
  • current-screen

Old fullscreen (--fullscreen and fullscreen = true) still working, this does the same as using "current-screen".

Adds option for initial resize

  • smart (existing behaviour) (e.g. --resize smart or resize = { mode = "smart" })
  • actual size (e.g. --resize 2000x800 or resize = { mode = "size", width=2000, height= 800 })

Adds option for the existing floating hack (--floating-hack or floating-hack=true), default is off.

  • WindowSizing in both command_line and configuration needs deduplicating
  • behaviour with different compositor settings for the window needs testing
  • reconsider default
  • consider all-screens
  • use options instead of None directly
  • consider changes from feat: monitor_scale #335 once those are merged

Requires #322 to be included before next release.

@RobertMueller2 RobertMueller2 force-pushed the resize_behaviour branch 2 times, most recently from 76b4825 to 3b5b82f Compare October 10, 2025 21:11
@RobertMueller2
Copy link
Member Author

RobertMueller2 commented Oct 11, 2025

I think I'll change this to
--fullscreen=all|current|none (with --fullscreen and fullscreen=true in config still working)
--resize-window=w,h|smart
--floating-hack

because these might be used in any combination. You could place Satty in Fullscreen and still want to have a floating, sized window if you exit fullscreen. I think this should work better for the control flow in main.rs.

EDIT: included above

@RobertMueller2 RobertMueller2 marked this pull request as ready for review October 11, 2025 15:47
@RobertMueller2 RobertMueller2 marked this pull request as draft October 12, 2025 06:30
@RobertMueller2 RobertMueller2 marked this pull request as ready for review October 12, 2025 07:35
@RobertMueller2 RobertMueller2 force-pushed the resize_behaviour branch 2 times, most recently from 856c39d to 7fb82dc Compare October 14, 2025 06:42
@RobertMueller2 RobertMueller2 added this to the 0.20.1 milestone Oct 18, 2025
@RobertMueller2 RobertMueller2 force-pushed the resize_behaviour branch 2 times, most recently from 416a919 to bdd1a67 Compare October 31, 2025 08:29
@RobertMueller2 RobertMueller2 marked this pull request as draft November 30, 2025 08:56
@RobertMueller2
Copy link
Member Author

Changing back to draft so we can include #335 here.

PR Satty-org#335 introduced `--input-scale`, which needs to be considered in this
PR as well.
@RobertMueller2 RobertMueller2 marked this pull request as ready for review January 18, 2026 18:42
@RobertMueller2
Copy link
Member Author

updated for PR #335.

Check errors may be temporary, will try again later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: Command-line parameter to override size (or perhaps disable resizing-on-init completely)

1 participant