feat: initial-size config and command line#302
Open
RobertMueller2 wants to merge 2 commits intoSatty-org:mainfrom
Open
feat: initial-size config and command line#302RobertMueller2 wants to merge 2 commits intoSatty-org:mainfrom
RobertMueller2 wants to merge 2 commits intoSatty-org:mainfrom
Conversation
76b4825 to
3b5b82f
Compare
Member
Author
|
I think I'll change this to because these might be used in any combination. You could place Satty in Fullscreen and still want to have a floating, sized window if you exit fullscreen. I think this should work better for the control flow in EDIT: included above |
1dd7292 to
4499c6e
Compare
856c39d to
7fb82dc
Compare
416a919 to
bdd1a67
Compare
Merged
Member
Author
|
Changing back to draft so we can include #335 here. |
bdd1a67 to
885dae7
Compare
885dae7 to
df7542c
Compare
df7542c to
6b7fbbb
Compare
6b7fbbb to
2738519
Compare
PR Satty-org#335 introduced `--input-scale`, which needs to be considered in this PR as well.
2738519 to
813f91e
Compare
Member
Author
|
updated for PR #335. Check errors may be temporary, will try again later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #71
Changes fullscreen (command line and config) to use a parameter:
Old fullscreen (
--fullscreenandfullscreen = true) still working, this does the same as using "current-screen".Adds option for initial resize
--resize smartorresize = { mode = "smart" })--resize 2000x800orresize = { mode = "size", width=2000, height= 800 })Adds option for the existing floating hack (
--floating-hackorfloating-hack=true), default is off.Requires #322 to be included before next release.