feat: use adwaita headerbar vars for toolbar style#398
Open
RobertMueller2 wants to merge 1 commit intoSatty-org:mainfrom
Open
feat: use adwaita headerbar vars for toolbar style#398RobertMueller2 wants to merge 1 commit intoSatty-org:mainfrom
RobertMueller2 wants to merge 1 commit intoSatty-org:mainfrom
Conversation
Closes: Satty-org#213 Closes: Satty-org#396 Adwaita provides [theme variables for headerbars](https://gnome.pages.gitlab.gnome.org/libadwaita/doc/1-latest/css-variables.html#header-bar-colors), use those instead of hardcoded values. Also, move default css into its own file (Satty-org#213). The current implementation adds the overrides.css file to the same provider. This clears all default settings. This commit addresses this by adding an additional provider if the overrides file is present. Lastly, mention override in README.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #213
Closes: #396
Adwaita provides theme variables for
headerbars, use those instead of hardcoded values.
Also, move default css into its own file (#213).
The current implementation adds the overrides.css file to the same provider. This clears all default settings. This commit addresses this by adding an additional provider if the overrides file is present.
Lastly, mention override in README.