Auto-connect to existing server instead of restarting#8
Merged
SawyerHood merged 2 commits intomainfrom Dec 16, 2025
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- Make `connect()` default to `http://localhost:9222` so callers don't need to pass a URL - Change `start-server.ts` to no-op if server is already running instead of killing it - Keep CDP port cleanup for crash recovery (when Node dies but Chrome is still running) - Update SKILL.md documentation examples to use `connect()` without arguments 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
14b7a28 to
5957d58
Compare
- Add prominent callout warning that scripts must run from skills/dev-browser/ - Explain why: @/ path alias is configured in that directory's config files - Add setViewportSize to basic template to prevent screenshot errors 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
connect()default tohttp://localhost:9222so callers don't need to pass a URLstart-server.tsto no-op if server is already running instead of killing existing processesconnect()without argumentsTest plan
bun run start-serverconnect()without URL argument connects successfullybun x tsc --noEmitpassesbun run testpasses🤖 Generated with Claude Code