Skip to content

Extend vm_disk module tests - assert on vm_info output #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
justinc1 merged 1 commit into from
Jan 31, 2025
Merged

Extend vm_disk module tests - assert on vm_info output #351

justinc1 merged 1 commit into from
Jan 31, 2025

Conversation

@justinc1
Copy link
Collaborator

@justinc1 justinc1 commented Jan 31, 2025

Using vm_info means we test what vm_disk actually changed on HyperCore cluster, not only what vm_disk return value (e.g. what vm_disk thinks it applied).

@justinc1
Extend vm_disk module tests - assert on vm_info output
48c18a7 
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
@justinc1 justinc1 self-assigned this Jan 31, 2025
@justinc1
Copy link
Collaborator Author

justinc1 commented Jan 31, 2025

https://github.com/ScaleComputing/HyperCoreAnsibleCollection/actions/runs/13067636820 passed on all HyperCore versions

@justinc1 justinc1 merged commit 84865da into main Jan 31, 2025
41 checks passed
@justinc1 justinc1 deleted the vm_disk_test branch January 31, 2025 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@justinc1 justinc1

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@justinc1