ThunderKittens (w/ Blackwell) Support #104
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kittens repo to the root!
Collaborator
Author
|
@simonguozirui @willhu-jpg I opened a new more simplified PR that uses torch load_inline and clones the TK repo to the modal. In my view that version is a lot better (much less code change, I can't think of too many advantages to this much more complicated approach). Let me know if I should close this! This separate .cu/.py version is compatible with our old set of kernels we generated for CS 191W, I will keep it on my fork for legacy reasons in case we need it. Link to the (better) PR: #107 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@simonguozirui We need to discuss software design decisions