This repository was archived by the owner on Apr 22, 2024. It is now read-only.
Conversation
… the dataset logbook independently from the permissions
minottic
reviewed
Nov 15, 2022
| where: { ownerGroup: { inq: options.currentGroups } }, | ||
| }); | ||
| let proposals = {}; | ||
| if ( options.currentGroups.includes("admin") ) { |
Member
There was a problem hiding this comment.
isn't this managed already by the onwable model: https://github.com/SciCatProject/backend/blob/master/common/models/ownable.js#L16-L43?
Member
Author
There was a problem hiding this comment.
I do not think so, at least, I did not find this feature.
Before my change, access to the logbook was still managed locally. I juts extended the logic to include access groups.
Member
There was a problem hiding this comment.
I thought that the find of every method which inherits from ownable calls the before("access") operation hook, thus the lines that I've shared. The check there would be on global access though rather than admin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR enables users with access to dataset or admin privileges to view the logbook associated with the dataset itself.
A new function has been added to the logbook model and a new endpoint to the dataset which returns the logbook associated with it if it exists.
Motivation
In the previous version, only dataset owners could see the logbook. Not even admin could see it.
Tests included/Docs Updated?