Fix WENOScheme to accept epsilon as keyword argument #497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation and docstring stated that epsilon should be a keyword argument, but the function was defined with a positional argument. This caused a MethodError when users tried to use WENOScheme(epsilon=1e-6) as shown in the documentation. Fixes SciML#472 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
epsilonas a keyword argument, matching the documentation and docstringThe docstring explicitly said "## Keyword Arguments" and documented
epsilonas a keyword argument, but the function signature wasWENOScheme(epsilon = 1e-6)(positional) instead ofWENOScheme(; epsilon = 1e-6)(keyword).This caused users to get
MethodError: no method matching WENOScheme(; epsilon::Float64)when following the documentation.Fixes #472
Test plan
WENOScheme(epsilon=1e-6)now works (was failing before)WENOScheme()still works with default valuecc @ChrisRackauckas
🤖 Generated with Claude Code