Skip to content

Conversation

@apbendi
Copy link
Member

@apbendi apbendi commented Mar 4, 2025

  • The CI job on coverage should only run unit tests, not invariant tests, and it does not need many fuzz runs of these tests just to ensure the code is covered.
  • Bump to solc v0.8.28 and forge-std v1.9.6

apbendi added 2 commits March 4, 2025 08:57
The CI job on coverage should only run unit tests, not invariant tests, and it
does not need many fuzz runs of these tests just to ensure the code is coverged.
@github-actions
Copy link

github-actions bot commented Mar 4, 2025

Coverage after merging coverage-tweaks into main will be

100.00%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   Counter.sol100%100%100%100%

@apbendi apbendi marked this pull request as ready for review March 4, 2025 14:06
@wildmolasses
Copy link

lgtm. the change affects the coverage job only, not the test job, and i cant think of a good reason why we need more iterations on coverage, as i imagine our tests are specific enough to cover all statements/branches (and the weighted foundry dictionary ought to supplement well)

@apbendi apbendi merged commit 0fdbe76 into main Mar 4, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants