Creating main page #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ala-n
reviewed
Mar 19, 2018
task3/mainPage.html
Outdated
|
|
||
|
|
||
|
|
||
| <div class="main-middle"> |
task3/mainPage.html
Outdated
| </header> | ||
| <body> | ||
|
|
||
| <div class="container"> |
| <html lang="en"> | ||
| <head> | ||
| <meta charset="UTF-8"> | ||
| <link href="css/style.css" rel='stylesheet' type='text/css'> |
There was a problem hiding this comment.
но он у тебя не лежит в директории css ...
task3/mainPage.html
Outdated
| <div class="post-filters"> | ||
| <div class="post-filters-left"> | ||
|
|
||
| <div class="div-filter-1"> |
There was a problem hiding this comment.
filter-block
filter-wrapper
но без цифр, и всетаки без названий тегов...
task3/mainPage.html
Outdated
|
|
||
| </div> | ||
|
|
||
| <div class="card"> |
task3/mainPage.html
Outdated
| <div class="card"> | ||
| <div class="card--content"> | ||
| <div class="post-header"> | ||
| <input type="image" src="img/cross.png" class="delete-button"> |
There was a problem hiding this comment.
<button><img src=".." alt=".."></button>
input type="image" это о другом
task3/mainPage.html
Outdated
| </div> | ||
|
|
||
| </body> | ||
| <footer> |
ala-n
approved these changes
Mar 26, 2018
task3/mainPage.html
Outdated
| </div> | ||
| </div> | ||
| </header> | ||
| <div class="filter-page-part"> |
|
|
||
| </div> | ||
|
|
||
| <div class="cards"> |
There was a problem hiding this comment.
обертки в тег main не вижу, см семантическая верстка.
task3/mainPage.html
Outdated
| <title>Title</title> | ||
| </head> | ||
| <body> | ||
| <div class="main"> |
task3/mainPage.html
Outdated
| <div class="cards"> | ||
| <div class="cards-content"> | ||
| <div class="post-header"> | ||
| <a href="#" class="delete-button"> <img src="img/cross.png" title="Delete post" class="del-add-post-image"> </a> |
There was a problem hiding this comment.
alt text для картинок, единственное место где спорно нужен пустой alt или не нужен это сама картинка поста, в остальных случаях должен быть alt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.