Skip to content

Conversation

@L-Henke
Copy link
Contributor

@L-Henke L-Henke commented Mar 18, 2015

Fixup for 81051c6.
Since getSupportFragmentManager has been replaced with
getFragmentManager, anim folder has to be renamed to animator or
animations can not be found.

Fixup for 81051c6.
Since getSupportFragmentManager has been replaced with
getFragmentManager, anim folder has to be renamed to animator or
animations can not be found.
@L-Henke
Copy link
Contributor Author

L-Henke commented Mar 18, 2015

To clarify this: PR #116 is broken and the app crashed on start. Normally I test all branches before merging them, but now I relied an Travis, because everything was buildable and I didn't saw any possible errors.
I'll continue to do a basic test for all branches in the future.

@StelianMorariu
Copy link
Contributor

I'll be more careful next time. :(

@L-Henke
Copy link
Contributor Author

L-Henke commented Mar 18, 2015

Not your fault. I should have tested before merging it. Mistakes happen. See #123 :)

@Doplgangr
Copy link
Contributor

Yea sometimes I rely on gut instincts too and mistakes happen.

I looked at #123 and I was like "yea, that makes sense" and pushed the
merge button without hesitation.

I'll be testing everything too in future merges.

On Wed, Mar 18, 2015 at 9:40 PM, L-Henke notifications@github.com wrote:

Not your fault. I should have tested before merging it. Mistakes happen.
See #123 #123 :)


Reply to this email directly or view it on GitHub
#121 (comment)
.

@StelianMorariu
Copy link
Contributor

I get RuntimeException: Unknown animator name: alpha when trying to run the app in a Genymotion emulator.

@L-Henke
Copy link
Contributor Author

L-Henke commented Mar 18, 2015

Thats the exception I got before this fix. Maybe you should run gradle clean and compile it again.

The animators doesn't work with the native FragmentManager. Instead of
figuring out how to adapt them, I just removed them.
@L-Henke
Copy link
Contributor Author

L-Henke commented Mar 18, 2015

Since the animators does not work with the native FragmentManager, I just removed all custom animations. I think this is quicker now than figuring out how to adapt them. We can re-add them later if someone is willing to adapt the animations.

@Doplgangr
Copy link
Contributor

Sure. Amins are just non-essential components

@StelianMorariu
Copy link
Contributor

The app is starting, can open vault, can open picture from vault.
It looks good.

@StelianMorariu StelianMorariu mentioned this pull request Mar 20, 2015
@StelianMorariu
Copy link
Contributor

Sorry if I'm stepping on your toes, but master is broken and it's difficult to create new PR without this merge

StelianMorariu added a commit that referenced this pull request Mar 20, 2015
Renamed anim folder to animator
@StelianMorariu StelianMorariu merged commit b21f6bf into SecrecySupportTeam:master Mar 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants