[FEAT]: Replace Rust specific protocol definitions with protobufs#3
Merged
[FEAT]: Replace Rust specific protocol definitions with protobufs#3
protobufs#3Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the custom Rust-specific protocol definitions with protobuf definitions across the codebase, updating serialization/deserialization and relevant dependencies accordingly. Key changes include:
- Removal of the custom protocol module (protocol.rs) and addition of the protobuf definitions (protocol/bonka.proto).
- Introduction of a new proto module (proto.rs) and updating conversions in the key-value store (kv.rs) to work with the new protobufs.
- Adjustments in the benchmarking and build configuration files to support protobuf code generation and usage.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/protocol.rs | Removed obsolete protocol definitions. |
| src/proto.rs | Added module to include generated protobuf definitions. |
| src/lib.rs | Updated module import from protocol to proto. |
| src/kv.rs | Added conversions between KV Value enum and protobuf Value. |
| protocol/bonka.proto | Added protobuf definitions for Value, Command, Request, Response. |
| build.rs | Updated to compile the protobuf definitions via prost_build. |
| benches/bonka_benchmark.rs | Revised to use protobuf serialization and deserialization. |
| Cargo.toml | Added dependencies for prost, prost-types, and prost-build. |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #3 +/- ##
==========================================
+ Coverage 90.31% 91.61% +1.29%
==========================================
Files 8 7 -1
Lines 1064 1204 +140
==========================================
+ Hits 961 1103 +142
+ Misses 103 101 -2 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
protocol.rsserver.rsto use the protobufsprotobufValueenum and the KV'sValueenum.