Issue-134 - handle HTML-formatted SMW values in select field comparison #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Check if a value is wrapped in <span class="smw-value"> and extract the actual raw value before comparison. This prevents previously selected values from being lost when editing the form again.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #135 +/- ##
============================================
- Coverage 60.26% 60.00% -0.27%
- Complexity 103 105 +2
============================================
Files 8 8
Lines 526 530 +4
Branches 44 44
============================================
+ Hits 317 318 +1
- Misses 168 171 +3
Partials 41 41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@krabina The PR is ready to be checked and merged. |
krabina
approved these changes
Apr 16, 2025
Contributor
krabina
left a comment
krabina
left a comment
There was a problem hiding this comment.
Thank you, I can confirm that this fixes the issue!
Contributor
Author
|
@krabina Great news. Then this PR can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to the issue #134.
This PR contains: