Conversation
MatthewDeNapoli
requested changes
Apr 20, 2024
| char attrs2[num_attrs][5] = {"sve","sve2"}; | ||
| for (i = 0; i < attrnum; i++) | ||
| { | ||
| char *attr = attrs[i]; |
Collaborator
There was a problem hiding this comment.
This change seems like it would break attributes normally?
You're not parsing attrs[i] anymore and you're replacing it with your own.
Can you create a copy of the attrs char array and add the two extra strings for sve and sve2?
code-Gambler
requested changes
Apr 23, 2024
Collaborator
code-Gambler
left a comment
code-Gambler
left a comment
There was a problem hiding this comment.
In line 348 the array is initialized
char **attrs = XNEWVEC (char *, attrnum);
now instead of initializing it with attrnum you can initialize it with attrnum + 2 and after that append the array with "sve" and "sve2"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for taking the time to contribute to GCC! Please be advised that if you are
viewing this on
github.com, that the mirror there is unofficial and unmonitored.The GCC community does not use
github.comfor their contributions. Instead, we usea mailing list (
gcc-patches@gcc.gnu.org) for code submissions, code reviews, andbug reports. Please send patches there instead.