Skip to content

Better GET and POST error handling/error #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
grimzy wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Better GET and POST error handling/error #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/Oauth2Client.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,15 @@ protected function _post($url, $params = array(), $headers = array(), $auth = ar

$postOptions['verify'] = false;

$res = $client->request('post', $url, $postOptions);
try {
$res = $client->request('post', $url, $postOptions);
} catch (\GuzzleHttp\Exception\ClientException $e) {
$response = $e->getResponse();
$responseBodyAsString = $response->getBody()->getContents();
Copy link

@winswangg winswangg Sep 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question, will there alway be response body and content?

return json_decode($responseBodyAsString);
} catch (\Exception $e) {
return json_encode($e->getMessage());
}

//echo $res->getStatusCode(); // "200"
//echo $res->getHeader('content-type'); // 'application/json; charset=utf8'
Expand All @@ -329,6 +337,10 @@ protected function _get($url)
'Content-type' => 'application/json'
)
));
} catch (\GuzzleHttp\Exception\ClientException $e) {
$response = $e->getResponse();
$responseBodyAsString = $response->getBody()->getContents();
return json_decode($responseBodyAsString);
} catch (\Exception $e) {
return json_encode($e->getMessage());
}
Expand Down