Fix segfault in NormalizeComponentsUnitInterval::train() #298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change RealVector to DataType for min/max variables in train() method. When the template is instantiated with a different vector type (e.g., remora::vector<double, remora::cpu_tag>), the implicit conversion from the element proxy to RealVector fails, causing a segmentation fault. Fixes Shark-ML#285
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix segmentation fault in
NormalizeComponentsUnitInterval::train()when using non-default template types.Problem
When the
NormalizeComponentsUnitIntervaltemplate is instantiated with a vector type other thanRealVector(e.g.,remora::vector<double, remora::cpu_tag>), thetrain()method crashes with a segmentation fault at:The implicit conversion from the element proxy object to
RealVectorfails for non-default types.Solution
Change
RealVectortoDataTypefor theminandmaxvariables, ensuring the correct type is used based on the template parameter.Fixes #285