Skip to content
This repository was archived by the owner on Aug 30, 2018. It is now read-only.

Fix for issue #525 #533

Open
js42721 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix for issue #525 #533

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5c7488
Fix for issue #525
js42721 May 7, 2016
34037f3
Update timber.js.liquid
js42721 May 7, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions assets/timber.js.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,7 @@ timber.productPage = function (options) {

// Selectors
var $productImage = $('#ProductPhotoImg'),
$thumbImages = $('#ProductThumbs').find('a.product-single__thumbnail'),
$addToCart = $('#AddToCart'),
$productPrice = $('#ProductPrice'),
$comparePrice = $('#ComparePrice'),
Expand All @@ -218,7 +219,15 @@ timber.productPage = function (options) {
// Update variant image, if one is set
if (variant.featured_image) {
var newImg = variant.featured_image,
el = $productImage[0];
el = $productImage[0],
pattern = /[?&]v=([^&#]*)/,
v = pattern.exec(newImg.src)[1];
$thumbImages.each(function() {
if (pattern.exec($(this).attr('href'))[1] === v) {
newImg.alt = $(this).find('img').attr('alt');
return false;
}
});
Shopify.Image.switchImage(newImg, el, timber.switchImage);
}

Expand Down Expand Up @@ -265,7 +274,8 @@ timber.productImageSwitch = function () {
timber.cache.$thumbImages.on('click', function(evt) {
evt.preventDefault();
var newImage = $(this).attr('href');
timber.switchImage(newImage, null, timber.cache.$productImage);
var newImageAlt = $(this).find('img').attr('alt');
timber.switchImage(newImage, { alt: newImageAlt }, timber.cache.$productImage);
});
}
};
Expand All @@ -274,6 +284,7 @@ timber.switchImage = function (src, imgObject, el) {
// Make sure element is a jquery object
var $el = $(el);
$el.attr('src', src);
$el.attr('alt', imgObject.alt);
};

timber.responsiveVideos = function () {
Expand Down