Return false when deleting a non-existing key #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drinkbeer
force-pushed
the
jchen/fix_delete_non_existing_key
branch
4 times, most recently
from
d980398 to
16a1756
Compare
drinkbeer
force-pushed
the
jchen/fix_delete_non_existing_key
branch
from
16a1756 to
ef0e423
Compare
drinkbeer
force-pushed
the
jchen/fix_delete_non_existing_key
branch
from
072f0b1 to
798fdfe
Compare
drinkbeer
force-pushed
the
jchen/fix_delete_non_existing_key
branch
from
6fe3c7f to
668cc17
Compare
casperisfine
approved these changes
Apr 10, 2025
Contributor
casperisfine
left a comment
casperisfine
left a comment
There was a problem hiding this comment.
This is consistent with builtin stores in Rails, so 👍
rafaelfranca
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description