Simplify Rust node generation with explicit naming #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
alexcrocha
force-pushed
the
ar-simplify-rust-node-generation
branch
from
51c7833 to
7c61c38
Compare
st0012
reviewed
Oct 16, 2025
alexcrocha
force-pushed
the
ar-simplify-rust-node-generation
branch
from
7c61c38 to
ca7e472
Compare
st0012
approved these changes
Oct 16, 2025
Instead of auto-generating nested module paths from RBS nested naming conventions, use explicit rust_name fields in config.yml and generate flat structs. - Add rust_name field to all node definitions in config.yml - Remove complex module/path parsing logic from build.rs - Generate flat structs (e.g., ClassNode) instead of nested modules - Add Node enum to wrap all node types This makes the generated Rust code easier to work with.
alexcrocha
force-pushed
the
ar-rust-rbs-build
branch
from
5a39ac7 to
34c1f20
Compare
alexcrocha
force-pushed
the
ar-simplify-rust-node-generation
branch
from
ca7e472 to
211f8fe
Compare
This was referenced Oct 22, 2025
Merged
This was referenced Nov 18, 2025
Merged
Merged
Merged
This was referenced Nov 27, 2025
Merged
This was referenced Dec 9, 2025
Merged
This was referenced Dec 18, 2025
alexcrocha
added a commit
that referenced
this pull request
Jan 13, 2026
## Add explicit Rust names for AST nodes and simplify code generation Instead of auto-generating nested module paths from RBS nested naming conventions, use explicit `rust_name` fields in `config.yml` and generate flat structs. - Add `rust_name` field to all node definitions in `config.yml` - Remove complex module/path parsing logic from build.rs - Generate flat structs (e.g., `ClassNode`) instead of nested modules - Add `Node` enum to wrap all node types This makes the generated Rust code easier to work with.
alexcrocha
added a commit
that referenced
this pull request
Jan 13, 2026
## Add explicit Rust names for AST nodes and simplify code generation Instead of auto-generating nested module paths from RBS nested naming conventions, use explicit `rust_name` fields in `config.yml` and generate flat structs. - Add `rust_name` field to all node definitions in `config.yml` - Remove complex module/path parsing logic from build.rs - Generate flat structs (e.g., `ClassNode`) instead of nested modules - Add `Node` enum to wrap all node types This makes the generated Rust code easier to work with.
This was referenced Jan 13, 2026
Merged
Merged
alexcrocha
added a commit
that referenced
this pull request
Jan 14, 2026
## Add explicit Rust names for AST nodes and simplify code generation Instead of auto-generating nested module paths from RBS nested naming conventions, use explicit `rust_name` fields in `config.yml` and generate flat structs. - Add `rust_name` field to all node definitions in `config.yml` - Remove complex module/path parsing logic from build.rs - Generate flat structs (e.g., `ClassNode`) instead of nested modules - Add `Node` enum to wrap all node types This makes the generated Rust code easier to work with.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add explicit Rust names for AST nodes and simplify code generation
Instead of auto-generating nested module paths from RBS nested naming conventions, use explicit
rust_namefields inconfig.ymland generate flat structs.rust_namefield to all node definitions inconfig.ymlClassNode) instead of nested modulesNodeenum to wrap all node typesThis makes the generated Rust code easier to work with.