Skip to content

Try simpler datagram aggregation #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jasonhl wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Try simpler datagram aggregation #408

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ca8910
Try simpler datagram aggregation
jasonhl Jan 21, 2026
2b26af4
Split tags with colon, symbolize keys
jasonhl Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 10 additions & 11 deletions lib/statsd/instrument/aggregator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ def increment(name, value = 1, tags: [], no_prefix: false)
return
end

tags = tags_sorted(tags)
tags = tags_normalized(tags)
key = packet_key(name, tags, no_prefix, COUNT)

@aggregation_state_mutex.synchronize do
Expand Down Expand Up @@ -213,7 +213,7 @@ def aggregate_timing(name, value, tags: [], no_prefix: false, type: DISTRIBUTION
return
end

tags = tags_sorted(tags)
tags = tags_normalized(tags)
key = packet_key(name, tags, no_prefix, type, sample_rate: sample_rate)

aggregation_state = nil
Expand All @@ -236,7 +236,7 @@ def gauge(name, value, tags: [], no_prefix: false)
return
end

tags = tags_sorted(tags)
tags = tags_normalized(tags)
key = packet_key(name, tags, no_prefix, GAUGE)

@aggregation_state_mutex.synchronize do
Expand Down Expand Up @@ -304,18 +304,17 @@ def do_flush(aggregation_state)
end
end

def tags_sorted(tags)
return "" if tags.nil? || tags.empty?
def tags_normalized(tags)
return {} if tags.nil? || tags.empty?

if tags.is_a?(Hash)
tags = tags.sort_by { |k, _v| k.to_s }.map! { |k, v| "#{k}:#{v}" }
else
tags.sort!
unless tags.is_a?(Hash)
tags = tags.to_h { |tag| tag.include?(":") ? tag.split(":") : [tag, ""] }.transform_keys(&:to_sym)
end
datagram_builder(no_prefix: false).normalize_tags(tags)

tags
end

def packet_key(name, tags = "".b, no_prefix = false, type = COUNT, sample_rate: CONST_SAMPLE_RATE)
def packet_key(name, tags = {}, no_prefix = false, type = COUNT, sample_rate: CONST_SAMPLE_RATE)
AggregationKey.new(
DatagramBuilder.normalize_string(name),
tags,
Expand Down