Added proof of concept for filtering#134
Open
allenselew wants to merge 2 commits intoSiegeEngineers:masterfrom
Open
Added proof of concept for filtering#134allenselew wants to merge 2 commits intoSiegeEngineers:masterfrom
allenselew wants to merge 2 commits intoSiegeEngineers:masterfrom
Conversation
allenselew
commented
Aug 25, 2023
| </div> | ||
| </div> | ||
| <div id="filtering"> | ||
| <button id="filtering__toggle">Enable Filtering</button> |
Author
There was a problem hiding this comment.
This would probably need to have a translation added for locales
Member
|
Sorry I have not gotten back to you on this, my August has been pretty busy. Your demonstration looks quite neat! I hope I can find time to check it out in more detail in the coming days. |
Member
|
After having a proper look, some things to consider:
|
|
wow, this is an amazing feature. any plan on merging it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey SiegeEngineers,
Thanks for all your work on this project so far. It's the best aoe2 tech tree on the internet for sure.
This PR is a proof of concept to add a filtering mode which allows users to quickly answer questions like "Which civs have Arbalest, Thumb Ring, and Heavy Cav Archer?". Normally that would require looking at three separate tooltips' advanced stats and discerning the union of highlighted civs. Not so easy at a glance:
I figured it'd be easier if I could just click on all the techs I was interested in and see one list of civs that have access to all of the selected filters.
You can see a quick example of filtering in this gif below:

I don't think the level of design/polish here is anywhere close to being ready to merge, but figured I'd put it up to generate discussion and see if this is the kind of feature that would fit into this app. If not, perhaps it'd be something I could contribute as a separate site for SiegeEngineers.
Cheers!